Skip to content

Improve conditionals #10654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Improve conditionals #10654

merged 1 commit into from
Oct 13, 2025

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 13, 2025 •
edited
Loading

Conditionals changes extracted from #10600.

@cdce8p cdce8p added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 13, 2025
@Pierre-Sassoulas
Copy link
Member

This probably should be backported unless we plan to release 4.1 quick

@cdce8p
Copy link
Member Author

cdce8p commented Oct 13, 2025 •
edited
Loading

This probably should be backported unless we plan to release 4.1 quick

Sure. Added the backport label. Not sure about 4.1 just yet. The multithreading bug fixes are quite compelling though (at least for Home Assistant).

@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.96%. Comparing base (b970208) to head (9b32ce7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pylint/checkers/spelling.py 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (95.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10654   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         176      176           
  Lines       19521    19525    +4     
=======================================
+ Hits        18734    18738    +4     
  Misses        787      787
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.72% <100.00%> (ø)
pylint/checkers/classes/class_checker.py 94.01% <100.00%> (ø)
pylint/checkers/dataclass_checker.py 100.00% <100.00%> (ø)
pylint/checkers/design_analysis.py 98.42% <100.00%> (ø)
pylint/checkers/exceptions.py 98.30% <100.00%> (ø)
pylint/checkers/imports.py 94.88% <100.00%> (ø)
...int/checkers/refactoring/recommendation_checker.py 96.96% <100.00%> (ø)
pylint/checkers/refactoring/refactoring_checker.py 98.22% <100.00%> (ø)
pylint/checkers/stdlib.py 96.33% <100.00%> (ø)
pylint/checkers/strings.py 94.29% <100.00%> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 9b32ce7

@cdce8p cdce8p merged commit 91d3e26 into pylint-dev:main Oct 13, 2025
47 of 50 checks passed
@cdce8p cdce8p deleted the update-conditionals branch October 13, 2025 11:44
pylint-backport bot pushed a commit that referenced this pull request Oct 13, 2025
@cdce8p @pylint-backport
Improve conditionals (#10654)
191a05a 
(cherry picked from commit 91d3e26)
@pylint-backport pylint-backport bot mentioned this pull request Oct 13, 2025
Merged
cdce8p added a commit that referenced this pull request Oct 13, 2025
@pylint-backport @cdce8p
[Backport maintenance/4.0.x] Improve conditionals (#10655)
60a01e4 
Improve conditionals (#10654)

(cherry picked from commit 91d3e26)

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p mentioned this pull request Oct 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DudeNr33 DudeNr33 Awaiting requested review from DudeNr33 DudeNr33 is a code owner

Assignees

No one assigned

Labels

backport maintenance/4.0.x Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdce8p @Pierre-Sassoulas